Add higher-order horizontal pressure gradient design doc#448
Open
xylar wants to merge 1 commit into
Open
Conversation
xylar
force-pushed
the
omega/design/add-higher-order-hpg-design
branch
from
366d4ba to
7e05a15
Compare
sbrus89
reviewed
Jun 29, 2026
Comment on lines
+68
to
+69
| surface pressure, and coordinate slope. Convergence rate is a secondary diagnostic, not | ||
| the primary acceptance criterion. |
Collaborator
There was a problem hiding this comment.
Convergence rate seems like it should be more than a secondary diagnostic.
Author
There was a problem hiding this comment.
We can discuss this. We can have both be equally important acceptance criteria. But I maintain that the point of the higher-order implementation is not primarily to have the higher convergence rate but rather to have a smaller error at resolutions we actually use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist